Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Option from Array values (fixes #57) #359

Merged
merged 1 commit into from Nov 11, 2020

Conversation

djc
Copy link
Contributor

@djc djc commented Nov 11, 2020

As mandated by the spec change in open-telemetry/opentelemetry-specification#1214.

@djc djc requested a review from a team as a code owner November 11, 2020 12:39
@codecov
Copy link

codecov bot commented Nov 11, 2020

Codecov Report

Merging #359 (bd57056) into master (769592b) will decrease coverage by 0.01%.
The diff coverage is 30.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #359      +/-   ##
==========================================
- Coverage   54.21%   54.19%   -0.02%     
==========================================
  Files          70       70              
  Lines        5849     5836      -13     
==========================================
- Hits         3171     3163       -8     
+ Misses       2678     2673       -5     
Impacted Files Coverage Δ
opentelemetry/src/api/labels/mod.rs 0.00% <0.00%> (ø)
opentelemetry/src/api/core.rs 54.62% <33.33%> (-1.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 769592b...bd57056. Read the comment docs.

@jtescher jtescher merged commit 9c4f310 into open-telemetry:master Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants