Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Display trait for Key and Value types #353

Merged
merged 1 commit into from Nov 9, 2020

Conversation

djc
Copy link
Contributor

@djc djc commented Nov 9, 2020

This has the advantage that you can write these types into a string buffer without allocating. The split between &Value and Value From impls was not used efficiently in some of the other crates, and that is fixed here as well.

In addition, I believe this makes the API more idiomatic.

@djc djc requested a review from a team as a code owner November 9, 2020 09:46
@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #353 (353972c) into master (5cf034c) will decrease coverage by 0.19%.
The diff coverage is 37.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
- Coverage   54.21%   54.02%   -0.20%     
==========================================
  Files          69       70       +1     
  Lines        5829     5833       +4     
==========================================
- Hits         3160     3151       -9     
- Misses       2669     2682      +13     
Impacted Files Coverage Δ
opentelemetry/src/api/labels/encoder.rs 0.00% <0.00%> (ø)
opentelemetry/src/api/core.rs 55.72% <44.44%> (-1.31%) ⬇️
opentelemetry/src/api/baggage.rs 80.95% <66.66%> (ø)
opentelemetry/src/sdk/propagation/baggage.rs 96.42% <100.00%> (ø)
opentelemetry/src/exporter/trace/mod.rs 67.53% <0.00%> (-2.74%) ⬇️
opentelemetry/src/api/trace/tracer.rs 37.83% <0.00%> (-1.64%) ⬇️
opentelemetry/src/api/trace/noop.rs 68.26% <0.00%> (-0.67%) ⬇️
opentelemetry/src/testing/trace.rs 72.34% <0.00%> (-0.58%) ⬇️
...ntelemetry/src/sdk/metrics/aggregators/ddsketch.rs 78.28% <0.00%> (-0.32%) ⬇️
opentelemetry/src/sdk/trace/tracer.rs 74.50% <0.00%> (-0.17%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cf034c...353972c. Read the comment docs.

Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some new nightly clippy lints, but they can be addressed in subsequent PRs

@jtescher jtescher merged commit bd69642 into open-telemetry:master Nov 9, 2020
@djc
Copy link
Contributor Author

djc commented Nov 9, 2020

Oh, I didn't see those. None of them seem to be related to the changes here, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants