-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API reference "latest" pages should yield HTTP status 301 not 404 #1435
Comments
I am not sure why it is hosted on |
TIL! Let's update the docs site to point there for the API link too |
Submitted open-telemetry/opentelemetry.io#2508 |
I think we can consider this closed since we'll use the rubydoc link now. |
We might have more to discuss, see: Also, having the same content in two places, isn't a good idea for SEO etc. My guess is that GH pages is used for dev versions of the API reference? If not, and it's the same as rubydoc.info, then maybe it's time to drop the GH pages? At a minimum, the GH pages should all probably be marked noindex, nofollow, and in addition have an appropriate |
The one nice thing that the GH pages version gives us is index page with links to all the docs: https://open-telemetry.github.io/opentelemetry-ruby/ It would be kinda nice to keep that somehow. But otherwise yeah - I don't really see a huge need to keep hosting these on GH pages. Does anyone else even do that? That said - I'm really not sure exactly how these are getting generated today. I think it's a GitHub integration but because I'm only an approver on this repo, I can't actually see that. Maybe someone like @mwear with more admin privileges can check the settings pages and see if there's a github pages integration installed? (For what it's worth, the custom code that redirects can be found here on the gh-pages branch) |
👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
is this issue still a thing? |
Yes it is. The URL in the opening comment still returns 404. I haven't investigated if the same content in two places issue is still relevant. |
https://www.rubydoc.info/gems/opentelemetry-api still look very similar to me, so I guess there are still both places. |
We can have some of that on opentelemetry.io I guess:
|
👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
This is still relevant. |
👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the |
This is still relevant. |
Can a maintainer add the |
Visit one of the API reference pages and you'll initially get a 404, for example opentelemetry-sdk/latest:
If you open the same link in a browser, then the page redirects because it contains JS code that manipulates the window
location
to refer to the latest version of the appropriate Gem.Since API reference pages get redirected the proper HTTP status returned should be 301, not 404. Otherwise, that's bad for SEO and for link checkers -- e.g., see https://github.com/open-telemetry/opentelemetry.io/pull/2505/files#r1135889989.
/cc @cartermp @svrnm
The text was updated successfully, but these errors were encountered: