Update description of active requests counter for Django and aiohttp #2514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dkliban
added a commit
to dkliban/pulp-service
that referenced
this pull request
May 10, 2024
Due to an issue open-telemetry/opentelemetry-python-contrib#2513 We can remove the patch once open-telemetry/opentelemetry-python-contrib#2514 is released.
dkliban
added a commit
to dkliban/pulp-service
that referenced
this pull request
May 10, 2024
Due to an issue open-telemetry/opentelemetry-python-contrib#2513 We can remove the patch once open-telemetry/opentelemetry-python-contrib#2514 is released.
dkliban
added a commit
to dkliban/pulp-service
that referenced
this pull request
May 10, 2024
Due to an issue open-telemetry/opentelemetry-python-contrib#2513 We can remove the patch once open-telemetry/opentelemetry-python-contrib#2514 is released.
aabmass
reviewed
May 10, 2024
| @@ -213,7 +213,7 @@ async def middleware(request, handler): | |||
| active_requests_counter = meter.create_up_down_counter( | |||
| name=MetricInstruments.HTTP_SERVER_ACTIVE_REQUESTS, | |||
| unit="requests", | |||
| description="measures the number of concurrent HTTP requests those are currently in flight", | |||
| description="measures the number of concurrent HTTP requests that are currently in-flight", | |||
There was a problem hiding this comment.
@lmolkova updated the semantic convention package in open-telemetry/opentelemetry-python#3586 to generate instrument creation factories we could use here
@lmolkova would you recommend updating here to use create_http_server_active_requests()?
There was a problem hiding this comment.
yep, that would be great! if you see any issues/opportunities to improve, lmk, happy to update helpers.
There was a problem hiding this comment.
@dkliban could you update the PR to use this function for instrument creation?
There was a problem hiding this comment.
i'll try to do that. i haven't seen it actually used anywhere yet.
dkliban
added a commit
to dkliban/pulp-service
that referenced
this pull request
May 10, 2024
Due to an issue open-telemetry/opentelemetry-python-contrib#2513 We can remove the patch once open-telemetry/opentelemetry-python-contrib#2514 is released.
dkliban
added a commit
to dkliban/pulp-service
that referenced
this pull request
May 10, 2024
Due to an issue open-telemetry/opentelemetry-python-contrib#2513 We can remove the patch once open-telemetry/opentelemetry-python-contrib#2514 is released.
dkliban
added a commit
to pulp/pulp-service
that referenced
this pull request
May 10, 2024
Due to an issue open-telemetry/opentelemetry-python-contrib#2513 We can remove the patch once open-telemetry/opentelemetry-python-contrib#2514 is released.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2513