Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS Lambda event source key incorrect for SNS in instrumentation library. #2511

Open
mau-alex-ruiz opened this issue May 9, 2024 · 0 comments
Open

AWS Lambda event source key incorrect for SNS in instrumentation library. #2511

mau-alex-ruiz opened this issue May 9, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@mau-alex-ruiz
Copy link

Description
This line is checking for the key eventSource which will never be satisfied for SNS. Per AWS docs, the key is actually EventSource. The very simple fix would be to simply check for both eventSource and EventSource.

What is the expected behavior?
What did you expect to see?
span_kind for SNS event sources should be set to CONSUMER

What is the actual behavior?
span_kind for SNS event sources are being set to SERVER
@mau-alex-ruiz mau-alex-ruiz added the bug Something isn't working label May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mau-alex-ruiz