Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTelemetryCollector should have specific serviceAnnotations, podAnnotations, serviceLabels and podLabels settings #2884

Open
diranged opened this issue Apr 21, 2024 · 0 comments
Labels
enhancement New feature or request needs triage

Comments

@diranged
Copy link

Component(s)

collector

Is your feature request related to a problem? Please describe.

Today the operator copies the annotations and labels from the OpenTelemetryCollector objects to all of the resources it creates. This causes problems with tools like ArgoCD which use Annotations for resource tracking, so then the --annotations-filter flag was created. This is an unideal hack though because it's an all or nothing thing... and it means that we propagate labels and annotations to lots of resources where they don't make sense. For example, the service.kubernetes.io/topology-mode label has to be added to all the resources (clutster roles, pods, deployments, etc) when we really only want it on the service.

Describe the solution you'd like

I don't think that the Operator should automatically copy these Annotations or Labels at all ... and instead they should be defined as parameters.

Describe alternatives you've considered

No response

Additional context

No response

@diranged diranged added enhancement New feature or request needs triage labels Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage
Projects
None yet
Development

No branches or pull requests

1 participant