Move DefaultConfigProperties to autoconfigure-spi #5001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-berg
commented
Nov 29, 2022
| static DefaultConfigProperties customize( | ||
| DefaultConfigProperties previousProperties, Map<String, String> overrides) { | ||
| return new DefaultConfigProperties(previousProperties, overrides); | ||
| } |
There was a problem hiding this comment.
Adjusted this to be an instance method called withOverrides. Also renamed static DefaultConfigProperties get to create, so we now have consistently named factory methods for creating instances.
Codecov ReportBase: 91.23% // Head: 91.27% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #5001 +/- ##
============================================
+ Coverage 91.23% 91.27% +0.03%
- Complexity 4865 4866 +1
============================================
Files 552 552
Lines 14399 14399
Branches 1373 1373
============================================
+ Hits 13137 13142 +5
+ Misses 873 871 -2
+ Partials 389 386 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jkwatson
approved these changes
Nov 30, 2022
mateuszrzeszutek
approved these changes
Nov 30, 2022
dmarkwat
pushed a commit
to dmarkwat/opentelemetry-java
that referenced
this pull request
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4949.
As SPI implementations are added in various modules, the test code should follow, which requires some implementation of the
ConfigPropertiesinterface.This PR moves
DefaultConfigPropertiesto an internal package of:sdk-extensions:autoconfigure-spi. This gives implementers of SPIs (including us) a nice test utility, so long as they're willing to accept that the APIs may change.