From f5b8ab2fcf0f394b1b9e06aadfe57ea556a1edb4 Mon Sep 17 00:00:00 2001 From: Jason Plumb Date: Mon, 10 Oct 2022 13:41:42 -0700 Subject: [PATCH 1/3] ensure done before checking success to help troubleshoot timeout issues --- .../io/opentelemetry/sdk/autoconfigure/OtlpGrpcRetryTest.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sdk-extensions/autoconfigure/src/testOtlp/java/io/opentelemetry/sdk/autoconfigure/OtlpGrpcRetryTest.java b/sdk-extensions/autoconfigure/src/testOtlp/java/io/opentelemetry/sdk/autoconfigure/OtlpGrpcRetryTest.java index 7b080a74a15..833fb34d0ce 100644 --- a/sdk-extensions/autoconfigure/src/testOtlp/java/io/opentelemetry/sdk/autoconfigure/OtlpGrpcRetryTest.java +++ b/sdk-extensions/autoconfigure/src/testOtlp/java/io/opentelemetry/sdk/autoconfigure/OtlpGrpcRetryTest.java @@ -120,6 +120,10 @@ private static void testRetryableStatusCodes( CompletableResultCode resultCode = exporter.apply(dataSupplier.get()).join(10, TimeUnit.SECONDS); + assertThat(resultCode.isDone()) + .as("Exporter didn't complete in time. Consider increasing join timeout?") + .isTrue(); + boolean retryable = RetryUtil.retryableGrpcStatusCodes().contains(String.valueOf(code.value())); boolean expectedResult = retryable || code == Status.Code.OK; From 0f89bb505a1c1fc4c770636d05fceab7f1b22945 Mon Sep 17 00:00:00 2001 From: Jason Plumb Date: Tue, 11 Oct 2022 10:29:05 -0700 Subject: [PATCH 2/3] add done check to testDefaultRetryPolicy method as well. --- .../io/opentelemetry/sdk/autoconfigure/OtlpGrpcRetryTest.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sdk-extensions/autoconfigure/src/testOtlp/java/io/opentelemetry/sdk/autoconfigure/OtlpGrpcRetryTest.java b/sdk-extensions/autoconfigure/src/testOtlp/java/io/opentelemetry/sdk/autoconfigure/OtlpGrpcRetryTest.java index 833fb34d0ce..d44c4c43ec4 100644 --- a/sdk-extensions/autoconfigure/src/testOtlp/java/io/opentelemetry/sdk/autoconfigure/OtlpGrpcRetryTest.java +++ b/sdk-extensions/autoconfigure/src/testOtlp/java/io/opentelemetry/sdk/autoconfigure/OtlpGrpcRetryTest.java @@ -156,6 +156,9 @@ private static void testDefaultRetryPolicy( // Result should be failure, sever should have received maxAttempts requests CompletableResultCode resultCode = exporter.apply(dataSupplier.get()).join(10, TimeUnit.SECONDS); + assertThat(resultCode.isDone()) + .as("Exporter didn't complete in time. Consider increasing join timeout?") + .isTrue(); assertThat(resultCode.isSuccess()).isFalse(); assertThat(serverRequestCountSupplier.get()).isEqualTo(maxAttempts); } From f40f0b67fb97160241929fe98236ec8f8c9d8f14 Mon Sep 17 00:00:00 2001 From: Jason Plumb Date: Tue, 11 Oct 2022 13:55:25 -0700 Subject: [PATCH 3/3] ensure isDone() before other assertions --- .../opentelemetry/sdk/autoconfigure/OtlpHttpRetryTest.java | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/sdk-extensions/autoconfigure/src/testOtlp/java/io/opentelemetry/sdk/autoconfigure/OtlpHttpRetryTest.java b/sdk-extensions/autoconfigure/src/testOtlp/java/io/opentelemetry/sdk/autoconfigure/OtlpHttpRetryTest.java index dc81a25e374..501824f1c91 100644 --- a/sdk-extensions/autoconfigure/src/testOtlp/java/io/opentelemetry/sdk/autoconfigure/OtlpHttpRetryTest.java +++ b/sdk-extensions/autoconfigure/src/testOtlp/java/io/opentelemetry/sdk/autoconfigure/OtlpHttpRetryTest.java @@ -129,6 +129,10 @@ private static void testRetryableStatusCodes( CompletableResultCode resultCode = exporter.apply(dataSupplier.get()).join(10, TimeUnit.SECONDS); + assertThat(resultCode.isDone()) + .as("Exporter didn't complete in time. Consider increasing join timeout?") + .isTrue(); + boolean retryable = code != 200 && RetryUtil.retryableHttpResponseCodes().contains(code); boolean expectedResult = retryable || code == 200; assertThat(resultCode.isSuccess()) @@ -159,6 +163,9 @@ private static void testDefaultRetryPolicy( // Result should be failure, sever should have received maxAttempts requests CompletableResultCode resultCode = exporter.apply(dataSupplier.get()).join(10, TimeUnit.SECONDS); + assertThat(resultCode.isDone()) + .as("Exporter didn't complete in time. Consider increasing join timeout?") + .isTrue(); assertThat(resultCode.isSuccess()).isFalse(); assertThat(serverRequestCountSupplier.get()).isEqualTo(maxAttempts); }