Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement array (list) span attributes (spec#368) #801

Closed
Oberon00 opened this issue Jan 27, 2020 · 3 comments · Fixed by #807
Closed

Implement array (list) span attributes (spec#368) #801

Oberon00 opened this issue Jan 27, 2020 · 3 comments · Fixed by #807
Assignees
@carlosalberto @thisthat
Labels
API API related issues Holding On

Comments

@Oberon00
Copy link
Member

Oberon00 commented Jan 27, 2020 •
edited

open-telemetry/opentelemetry-specification#368 was merged but is not implemented in opentelemetry-java yet. Relevant wording change:

  • (Required) The attribute value, which is either:
    • A primitive type: string, boolean or numeric.
    • An array of primitive type values. The array MUST be homogeneous,
      i.e. it MUST NOT contain values of different types.
@arminru arminru added the API API related issues label Jan 27, 2020
@thisthat
Copy link
Member

I am preparing a PR for this

@thisthat thisthat mentioned this issue Jan 30, 2020
Merged
@thisthat thisthat mentioned this issue Feb 14, 2020
Closed
6 tasks
@thisthat
Copy link
Member

Pending on open-telemetry/opentelemetry-specification#459

@thisthat
Copy link
Member

thisthat commented Mar 4, 2020

After #807 is merged, we can close this issue!

@carlosalberto carlosalberto self-assigned this Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlosalberto carlosalberto

@thisthat thisthat

Labels
API API related issues Holding On
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Array values for span attributes dynatrace-oss-contrib/opentelemetry-java
5 participants
@carlosalberto @Oberon00 @thisthat @arminru and others