Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support mTLS for JaegerRemoteSampler when instantiated via JaegerRemoteSamplerProvider in autoinstrumentation #6061

Open
evantorrie opened this issue Dec 8, 2023 · 1 comment
Labels
Feature Request Suggest an idea for this project

Comments

@evantorrie
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I'd like to allow autoinstrumented Java code that elects to use otel.traces.sampler=jaeger_remote to be able to pass mTLS specific information to JaegerRemoteSamplerProvider. Currently there is no way to enable mTLS via the otel.traces.sampler.arg configuration parameter, as it supports only

  • endpoint
  • polling interval
  • initialSamplingRate

Describe the solution you'd like

Support for JaegerRemoteSampler mTLS communication via the otel.traces.sampler* configuration variables.

Describe alternatives you've considered

Write Otel-specific code in every Java application that wants to be auto-instrumented to call JaegerRemoteSamplerBuilder.set{ClientTls,TrustedCertificates} and somehow (likely via a custom Javaagent extension) override the sampler construction at SDK initialization time.

@evantorrie evantorrie added the Feature Request Suggest an idea for this project label Dec 8, 2023
@breedx-splk
Copy link
Contributor

@evantorrie At first glance, this doesn't seem too bad. The JaegerRemoteSamplerBuilder has these methods:

  • setSslContext
  • setClientTls
  • setTrustedCertificates

Do you think that those provide enough to get mTLS going? If so, then it would be a matter of determining what config properties would be needed to map into those.

Can you enumerate what the set of config properties would be needed to configure mTLS are?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Suggest an idea for this project
Projects
None yet
Development

No branches or pull requests

2 participants