Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serialization of arrays in prometheus exporter #5987

Open
trask opened this issue Nov 15, 2023 · 2 comments
Open

Fix serialization of arrays in prometheus exporter #5987

trask opened this issue Nov 15, 2023 · 2 comments
Labels
Bug Something isn't working

Comments

@trask
Copy link
Member

trask commented Nov 15, 2023

The spec says:

For protocols that do not natively support non-string values, non-string values SHOULD be represented as JSON-encoded strings.

but it looks like the Prometheus exporter calls only Object.toString():

@trask trask added the Bug Something isn't working label Nov 15, 2023
@fstab
Copy link
Member

fstab commented Nov 17, 2023

Just FYI: I started working on a PR for #5940, and that will replace the Serializer class. I'm confident I can get the PR done next week.

@fstab
Copy link
Member

fstab commented Nov 27, 2023

Quick update: If #6015 gets merged this code will be moved to Otel2PrometheusConverter.convertAttributes(). Still the same issue though, #6015 also calls value.toString().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants