Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenTracing Shim: Do not map semconv values from OT to OTel. #5016

Merged

Conversation

carlosalberto
Copy link
Contributor

Fixes #5004

Also removed related redundant assertions (i.e. SpanKind checks) for a few test cases in the testbed.

@carlosalberto carlosalberto requested a review from a team as a code owner December 3, 2022 17:20
@codecov
Copy link

codecov bot commented Dec 3, 2022

Codecov Report

Base: 91.27% // Head: 91.28% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (773bc11) compared to base (f490ba8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5016      +/-   ##
============================================
+ Coverage     91.27%   91.28%   +0.01%     
+ Complexity     4885     4880       -5     
============================================
  Files           552      552              
  Lines         14433    14418      -15     
  Branches       1373     1369       -4     
============================================
- Hits          13173    13161      -12     
+ Misses          874      873       -1     
+ Partials        386      384       -2     
Impacted Files Coverage Δ
...opentelemetry/opentracingshim/SpanBuilderShim.java 94.78% <100.00%> (+0.98%) ⬆️
...ava/io/opentelemetry/opentracingshim/SpanShim.java 91.07% <100.00%> (+0.80%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jkwatson jkwatson merged commit c6d1ec1 into open-telemetry:main Dec 5, 2022
dmarkwat pushed a commit to dmarkwat/opentelemetry-java that referenced this pull request Dec 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenTracing Shim: Do not perform semantic conventions mapping
3 participants