Fix concurrent modification exception in ComponentRegistry #4951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkwatson
reviewed
Nov 15, 2022
sdk/common/src/test/java/io/opentelemetry/sdk/internal/ComponentRegistryTest.java
Outdated
Show resolved
Hide resolved
jkwatson
approved these changes
Nov 15, 2022
Codecov ReportBase: 91.01% // Head: 91.02% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4951 +/- ##
============================================
+ Coverage 91.01% 91.02% +0.01%
Complexity 4841 4841
============================================
Files 546 546
Lines 14442 14447 +5
Branches 1395 1395
============================================
+ Hits 13144 13150 +6
+ Misses 893 892 -1
Partials 405 405
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
mateuszrzeszutek
approved these changes
Nov 15, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Nov 15, 2022
* Fix concurrent modification exception in ComponentRegistry * Reduce number of threads and iterations
jack-berg
added a commit
that referenced
this pull request
Nov 15, 2022
…4954) * Fix concurrent modification exception in ComponentRegistry * Reduce number of threads and iterations Co-authored-by: jack-berg <34418638+jack-berg@users.noreply.github.com> Co-authored-by: Jack Berg <jberg@newrelic.com>
dmarkwat
pushed a commit
to dmarkwat/opentelemetry-java
that referenced
this pull request
Dec 30, 2022
…metry#4951) * Fix concurrent modification exception in ComponentRegistry * Reduce number of threads and iterations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this bug today working on something else.