Add experimental ConditionalResourceProvider interface #4731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 90.60% // Head: 90.61% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #4731 +/- ##
=========================================
Coverage 90.60% 90.61%
- Complexity 4906 4908 +2
=========================================
Files 567 567
Lines 14728 14731 +3
Branches 1414 1416 +2
=========================================
+ Hits 13345 13348 +3
Misses 959 959
Partials 424 424
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
jack-berg
reviewed
Sep 2, 2022
| @@ -46,6 +47,10 @@ static Resource configureResource( | |||
| if (disabledProviders.contains(resourceProvider.getClass().getName())) { | |||
| continue; | |||
| } | |||
| if (resourceProvider instanceof ConditionalResourceProvider | |||
| && !((ConditionalResourceProvider) resourceProvider).shouldApply(config, result)) { | |||
| continue; | |||
jack-berg
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative implementation of #4718; we talked about this in yesterday's SIG meeting.
If this looks okay to you, I'll add some tests and mark it as ready for review.