Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop publishing opentelemetry-exporter-jaeger-proto artifact #4724

Merged
merged 2 commits into from Sep 8, 2022

Conversation

jack-berg
Copy link
Member

@jack-berg jack-berg commented Aug 25, 2022

Related to #4661 and #4701.

Adds tooling to the BOM conventions that allows artifacts to be included in the BOM which are no longer published. The first artifact to be referenced like this is :expoters:jaeger-proto (opentelemetry-exporter-jaeger-proto). I've added a test to to :all that confirms that the public classes of opentelemetry-exporter-jaeger-proto are still accessible when using the BOM.

Here's what the BOM looks like when I run ./gradlew publishToMavenLocal:

<?xml version="1.0" encoding="UTF-8"?>
<project xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 https://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns="http://maven.apache.org/POM/4.0.0"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <!-- This module was also published with a richer model, Gradle metadata,  -->
  <!-- which should be used instead. Do not delete the following line which  -->
  <!-- is to indicate to Gradle or any Gradle module metadata file consumer  -->
  <!-- that they should prefer consuming it instead. -->
  <!-- do_not_remove: published-with-gradle-metadata -->
  <modelVersion>4.0.0</modelVersion>
  <groupId>io.opentelemetry</groupId>
  <artifactId>opentelemetry-bom</artifactId>
  <version>1.18.0-SNAPSHOT</version>
  <packaging>pom</packaging>
  <name>OpenTelemetry Java</name>
  <description>OpenTelemetry Bill of Materials</description>
  <url>https://github.com/open-telemetry/opentelemetry-java</url>
  <licenses>
    <license>
      <name>The Apache License, Version 2.0</name>
      <url>http://www.apache.org/licenses/LICENSE-2.0.txt</url>
    </license>
  </licenses>
  <developers>
    <developer>
      <id>opentelemetry</id>
      <name>OpenTelemetry</name>
      <url>https://github.com/open-telemetry/community</url>
    </developer>
  </developers>
  <scm>
    <connection>scm:git:git@github.com:open-telemetry/opentelemetry-java.git</connection>
    <developerConnection>scm:git:git@github.com:open-telemetry/opentelemetry-java.git</developerConnection>
    <url>git@github.com:open-telemetry/opentelemetry-java.git</url>
  </scm>
  <dependencyManagement>
    <dependencies>
      <dependency>
        <groupId>io.opentelemetry</groupId>
        <artifactId>opentelemetry-context</artifactId>
        <version>1.18.0-SNAPSHOT</version>
      </dependency>
      <dependency>
        <groupId>io.opentelemetry</groupId>
        <artifactId>opentelemetry-api</artifactId>
        <version>1.18.0-SNAPSHOT</version>
      </dependency>
      /* Other dependencies omitted for brevity */
      <dependency>
        <groupId>io.opentelemetry</groupId>
        <artifactId>opentelemetry-exporter-jaeger-proto</artifactId>
        <version>1.17.0</version>
      </dependency>
    </dependencies>
  </dependencyManagement>
</project>

Notice the version for opentelemetry-exporter-jaeger-proto is different than the others.

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Base: 90.63% // Head: 90.60% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (eec4c04) compared to base (160af1c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #4724      +/-   ##
============================================
- Coverage     90.63%   90.60%   -0.03%     
+ Complexity     4907     4906       -1     
============================================
  Files           570      567       -3     
  Lines         14751    14728      -23     
  Branches       1413     1414       +1     
============================================
- Hits          13370    13345      -25     
- Misses          954      959       +5     
+ Partials        427      424       -3     
Impacted Files Coverage Δ
...esting/context/SettableContextStorageProvider.java 37.93% <0.00%> (-24.14%) ⬇️
...o/opentelemetry/api/internal/ReadOnlyArrayMap.java 91.11% <0.00%> (-2.23%) ⬇️
.../extension/noopapi/NoopContextStorageProvider.java
...elemetry/extension/noopapi/NoopTracerProvider.java
...telemetry/extension/noopapi/NoopOpenTelemetry.java
...elemetry/sdk/testing/assertj/AttributesAssert.java 98.86% <0.00%> (+0.19%) ⬆️
.../opentelemetry/exporter/prometheus/Serializer.java 86.44% <0.00%> (+0.42%) ⬆️
...telemetry/sdk/trace/export/BatchSpanProcessor.java 92.41% <0.00%> (+1.37%) ⬆️
...ava/io/opentelemetry/sdk/internal/RateLimiter.java 100.00% <0.00%> (+5.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jack-berg jack-berg changed the title Demonstrate publishing bom with old artifacts Stop publishing opentelemetry-exporter-jaeger-proto artifact Sep 7, 2022
@jack-berg jack-berg marked this pull request as ready for review September 7, 2022 20:40
@jack-berg jack-berg requested a review from a user September 7, 2022 20:40
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice gradle work 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants