Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike a bridge from new interfaces to current OpenTracing interfaces #4

Closed
tedsuo opened this issue Mar 19, 2019 · 4 comments
Closed
Assignees
Labels
Agreed Issues that the group agreed on.

Comments

@tedsuo
Copy link
Contributor

tedsuo commented Mar 19, 2019

  • the goal is backwards compatibility: prove that a new tracer – built only to support the new tracer interfaces – can consume existing OT instrumentation.
  • The goal for the spike is to identify and understand any places where the new interface design will make backwards compatibility difficult.
@tedsuo tedsuo added this to the Step 1: Spike to verify new API in Java milestone Mar 19, 2019
@tedsuo tedsuo changed the title Spike a bridge from the new interfaces to OpenTracing Spike a bridge from the interfaces to OpenTracing Mar 19, 2019
@tedsuo tedsuo changed the title Spike a bridge from the interfaces to OpenTracing Spike a bridge from new interfaces to current OpenTracing interfaces Mar 19, 2019
@bhs
Copy link

bhs commented Mar 19, 2019

@tedsuo @bogdandrutu to be clear, the goal here is to write an implementation of an opentracing.Tracer that calls into the OpenFoo machinery.

If so, I'd propose we rename this issue Spike an OpenTracing Tracer that calls into the new merged project (or anything else that's unambiguous about the "direction" of the adapter).

@tedsuo
Copy link
Contributor Author

tedsuo commented Mar 23, 2019

Thanks @bhs. I clarified this somewhat.

I would prefer that the bridge code takes in the new interface, and returns the old interface. So it will work with any new tracer, not just the SDK. Given that the OpenTracing API is very abstract, and generally does not have accessors, this should be possible.

So, something like this pseudocode:

NewOpenTracingBridge(consensus.Tracer) opentracing.Tracer

@tedsuo tedsuo removed this from the Step 1: Spike to verify new API in Java milestone Apr 19, 2019
@tedsuo tedsuo added Agreed Issues that the group agreed on. Action Required labels Apr 19, 2019
@jkwatson
Copy link
Contributor

The OpenTracingShim does this, correct? Can we close this issue?

@carlosalberto
Copy link
Contributor

Sure, this is done. There are a few missing items/improvements but we already have issues for those cases. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Agreed Issues that the group agreed on.
Projects
None yet
Development

No branches or pull requests

4 participants