New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spike a bridge from new interfaces to current OpenTracing interfaces #4
Comments
@tedsuo @bogdandrutu to be clear, the goal here is to write an implementation of an If so, I'd propose we rename this issue |
Thanks @bhs. I clarified this somewhat. I would prefer that the bridge code takes in the new interface, and returns the old interface. So it will work with any new tracer, not just the SDK. Given that the OpenTracing API is very abstract, and generally does not have accessors, this should be possible. So, something like this pseudocode: NewOpenTracingBridge(consensus.Tracer) opentracing.Tracer |
The OpenTracingShim does this, correct? Can we close this issue? |
Sure, this is done. There are a few missing items/improvements but we already have issues for those cases. Closing. |
The text was updated successfully, but these errors were encountered: