Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to create their own ZPageServer instance #1498

Closed
williamhu99 opened this issue Aug 3, 2020 · 1 comment
Closed

Allow users to create their own ZPageServer instance #1498

williamhu99 opened this issue Aug 3, 2020 · 1 comment
Labels
Feature Request Suggest an idea for this project release:after-ga

Comments

@williamhu99
Copy link
Contributor

Is your feature request related to a problem? Please describe.
At the moment, the /tracez zPage only logs spans created by the global OpenTelemetrySdk. This prevents users who are interested in zPages from using their own sdk.

Describe the solution you'd like
The ZPageServer class registers the zPages using the OpenTelemetrySdk. We should modify the class so that users can create their own ZPageServer instance and pass in their preferred sdk.

Additional context
This issue was originally brought up by John Watson here.
@williamhu99 williamhu99 added the Feature Request Suggest an idea for this project label Aug 3, 2020
@jkwatson
Copy link
Contributor

jkwatson commented Oct 9, 2020

closing as a duplicate of #1414

@jkwatson jkwatson closed this as completed Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request Suggest an idea for this project release:after-ga
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jkwatson @williamhu99