Replies: 4 comments 2 replies
-
Hi @shawnsong - sorry to hear about the production issue.
|
Beta Was this translation helpful? Give feedback.
-
Hi @anuraaga, Thanks for the prompt response.
Is this going to be the long-term solution or it's a workaround for now. Are there any plans to introduce the dynamic sample rate feature?
I can understand from the semantic versioning perspective. Would that be possible in the future? The spec is slightly vague in this area as what is considered as runtime vs configuration. Is it worth adding another method like |
Beta Was this translation helpful? Give feedback.
-
@shawnsong I am trying to do the same thing. We want the ability to update the trace sample rate/ratio at runtime. Did you end finding a working solution? Would you mind sharing it? |
Beta Was this translation helpful? Give feedback.
-
@shawnsong thank you for sharing the code. Would this code live in the extension or in the app? |
Beta Was this translation helpful? Give feedback.
-
Description
Our production systems recently experienced some issues caused by the
TraceIdRatioBasedSampler
. We use our own flag system to dynamically update the sample rate in our production. Our current way of changing the sample rate dynamically is by having a proxy class and re-initializing the real sampler inside the proxy class. The issue happened when an invalid sample rate was set in the flag system and exceptions were thrown when callingSampler.traceIdRatioBased()
. My questions are:try-catch
blocks everywhere in the codebase.Beta Was this translation helpful? Give feedback.
All reactions