From 5ac1cef1e8c6d911a35ab76fec0d2d53117a4b6c Mon Sep 17 00:00:00 2001
From: Michal Korzeniewski <37160097+mkorzeniewski@users.noreply.github.com>
Date: Tue, 25 Oct 2022 20:24:48 +0200
Subject: [PATCH] Add toString method to AbstractInstrument (#4883)

* Add toString method to AbstractInstrument

* add test for toString method

* use hasToString assertion for toString test
---
 .../io/opentelemetry/sdk/metrics/AbstractInstrument.java   | 5 +++++
 .../opentelemetry/sdk/metrics/AbstractInstrumentTest.java  | 7 +++++++
 2 files changed, 12 insertions(+)

diff --git a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/AbstractInstrument.java b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/AbstractInstrument.java
index cb0c3da9285..b23855caa6d 100644
--- a/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/AbstractInstrument.java
+++ b/sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/AbstractInstrument.java
@@ -39,4 +39,9 @@ public boolean equals(@Nullable Object o) {
   public int hashCode() {
     return descriptor.hashCode();
   }
+
+  @Override
+  public String toString() {
+    return this.getClass().getSimpleName() + "{" + "descriptor=" + getDescriptor() + '}';
+  }
 }
diff --git a/sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/AbstractInstrumentTest.java b/sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/AbstractInstrumentTest.java
index 63ca658c971..55515137e15 100644
--- a/sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/AbstractInstrumentTest.java
+++ b/sdk/metrics/src/test/java/io/opentelemetry/sdk/metrics/AbstractInstrumentTest.java
@@ -22,6 +22,13 @@ void getValues() {
     assertThat(testInstrument.getDescriptor()).isSameAs(INSTRUMENT_DESCRIPTOR);
   }
 
+  @Test
+  void testToString() {
+    TestInstrument testInstrument = new TestInstrument(INSTRUMENT_DESCRIPTOR);
+    assertThat(testInstrument)
+        .hasToString("TestInstrument{descriptor=" + INSTRUMENT_DESCRIPTOR + "}");
+  }
+
   private static final class TestInstrument extends AbstractInstrument {
     TestInstrument(InstrumentDescriptor descriptor) {
       super(descriptor);