Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move kafka spring starter test to spring smoke test project #11261

Closed
zeitlinger opened this issue Apr 30, 2024 · 5 comments · Fixed by #11262
Closed

move kafka spring starter test to spring smoke test project #11261

zeitlinger opened this issue Apr 30, 2024 · 5 comments · Fixed by #11262
Assignees

Comments

@zeitlinger
Copy link
Member

zeitlinger commented Apr 30, 2024

so that it can be tested with graalvm native

@trask
Copy link
Member

trask commented May 1, 2024

Do you think it's possible to run the normal instrumentation tests using native images, or is this a pattern we expect for all library instrumentation (creating smoke tests to test native images)?

@zeitlinger zeitlinger changed the title move kafka spring test to smoke test project move kafka spring starter test to spring smoke test project May 2, 2024
@zeitlinger
Copy link
Member Author

The title of this issue is misleading.

good catch - renamed

@zeitlinger
Copy link
Member Author

Do you think it's possible to run the normal instrumentation tests using native images, or is this a pattern we expect for all library instrumentation (creating smoke tests to test native images)?

@jeanbisutti can you explain?

@jeanbisutti
Copy link
Member

The potential perspectives:

  • Test the automatic instrumentations of the OTel Spring starter in the smoke-tests-otel-starter projet, both with a JVM runtime and a GraalVM native one
  • Later, move to real smoke tests in the smoke-tests-otel-starter project by using MockServer for example
  • Later, add tests in smoke-tests-otel-starter with the OTel starter used with instrumentation libraries (not Spring libraries), waiting for automatic instrumentation if the automatic instrumentation is possible (one of the first motivations of the smoke-tests-otel-starter project was to avoid regressions when the OTel Starter was used with the OTel log appenders and the JDBC instrumentation library, but both will have automatic instrumentation once Add automatic JDBC instrumentation to the OTel Spring starter #11258 is merged).

We need to verify the OTel starter compatibility with Spring Boot 2 (to detect potential issues with Java 17 code for example), so we would leave some tests in the spring-boot-autoconfigure project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants