add spring starter r2dbc support #11221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
test native
zeitlinger
force-pushed
the
spring-r2dbc
branch
from
86f5892
to
2071473
Compare
Options
|
zeitlinger
force-pushed
the
spring-r2dbc
branch
from
2071473
to
e692181
Compare
zeitlinger
force-pushed
the
spring-r2dbc
branch
2 times, most recently
from
d2cc50c
to
a23a8ba
Compare
jeanbisutti
reviewed
Apr 30, 2024
...metry/instrumentation/spring/autoconfigure/instrumentation/r2dbc/R2dbcAutoConfiguration.java
Show resolved
Hide resolved
...trumentation/spring/autoconfigure/instrumentation/r2dbc/R2dbcInstrumentingPostProcessor.java
Outdated
Show resolved
Hide resolved
...trumentation/spring/autoconfigure/instrumentation/r2dbc/R2dbcInstrumentingPostProcessor.java
Outdated
Show resolved
Hide resolved
...l-starter/spring-boot-3-reactive/src/main/java/io/opentelemetry/spring/smoketest/Player.java
Outdated
Show resolved
Hide resolved
instrumentation/spring/spring-boot-autoconfigure/build.gradle.kts
Outdated
Show resolved
Hide resolved
laurit
reviewed
May 2, 2024
...library/src/main/java/io/opentelemetry/instrumentation/r2dbc/v1_0/R2dbcTelemetryBuilder.java
Outdated
Show resolved
Hide resolved
zeitlinger
force-pushed
the
spring-r2dbc
branch
3 times, most recently
from
72e7b97
to
d6ca89b
Compare
laurit
approved these changes
May 3, 2024
|
@zeitlinger could you rebase so this could be merged |
…/io/opentelemetry/instrumentation/spring/autoconfigure/instrumentation/r2dbc/R2dbcAutoConfiguration.java Co-authored-by: Jean Bisutti <jean.bisutti@gmail.com>
laurit
reviewed
May 10, 2024
Comment on lines
+277
to
+280
| "name": "otel.instrumentation.common.db-statement-sanitizer.enabled", | ||
| "type": "java.lang.Boolean", | ||
| "description": "Enables the DB statement sanitization for R2DBC.", | ||
| "defaultValue": true |
There was a problem hiding this comment.
it is weird that this applies only to r2dbc, I'd assume that this would also apply to jdbc. I'd make the description more generic.
There was a problem hiding this comment.
no, this feature is missing for JDBC currently - but I'm happy to add that in a follow up PR 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #r2dbc