From 8f278af6e2dd90ad267d48c16c43b4c003d5aef3 Mon Sep 17 00:00:00 2001 From: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com> Date: Wed, 16 Mar 2022 14:49:48 +0000 Subject: [PATCH 1/6] Adds go1.18 to tests, moves default version to 1.17 --- .github/workflows/benchmark.yml | 2 +- .github/workflows/ci.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 8366db387dd..76309765c94 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -4,7 +4,7 @@ on: branches: - main env: - DEFAULT_GO_VERSION: 1.16 + DEFAULT_GO_VERSION: 1.17 jobs: benchmark: name: Benchmarks diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 353df7ce38d..b3030d751fb 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -8,7 +8,7 @@ env: # Path to where test results will be saved. TEST_RESULTS: /tmp/test-results # Default minimum version of Go to support. - DEFAULT_GO_VERSION: 1.16 + DEFAULT_GO_VERSION: 1.17 jobs: lint: runs-on: ubuntu-latest @@ -109,7 +109,7 @@ jobs: compatibility-test: strategy: matrix: - go-version: [1.17, 1.16] + go-version: [1.18, 1.17, 1.16] os: [ubuntu-latest, macos-latest, windows-latest] # GitHub Actions does not support arm* architectures on default # runners. It is possible to acomplish this with a self-hosted runner From 7c8a5be0461c4ccd9b6b931b98301521f09fa687 Mon Sep 17 00:00:00 2001 From: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com> Date: Wed, 16 Mar 2022 15:41:20 +0000 Subject: [PATCH 2/6] Added note to readme. --- CHANGELOG.md | 1 + README.md | 7 +++++++ 2 files changed, 8 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index b83debc78bc..ec36f20d8c3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -35,6 +35,7 @@ This update is a breaking change of the unstable Metrics API. Code instrumented Zero or negative values will not be changed to the default value like `WithSpanLimits` does. Setting a limit to zero will effectively disable the related resource it limits and setting to a negative value will mean that resource is unlimited. Consequentially, limits should be constructed using `NewSpanLimits` and updated accordingly. (#2637) +- Add go 1.18 to our compatibility tests. (#????) ### Changed diff --git a/README.md b/README.md index 21c2a71612e..cb57fc7127f 100644 --- a/README.md +++ b/README.md @@ -41,20 +41,27 @@ This project is tested on the following systems. | OS | Go Version | Architecture | | ------- | ---------- | ------------ | +| Ubuntu | 1.18 | amd64 | | Ubuntu | 1.17 | amd64 | | Ubuntu | 1.16 | amd64 | +| Ubuntu | 1.18 | 386 | | Ubuntu | 1.17 | 386 | | Ubuntu | 1.16 | 386 | +| MacOS | 1.18 | amd64 | | MacOS | 1.17 | amd64 | | MacOS | 1.16 | amd64 | +| Windows | 1.18 | amd64 | | Windows | 1.17 | amd64 | | Windows | 1.16 | amd64 | +| Windows | 1.18 | 386 | | Windows | 1.17 | 386 | | Windows | 1.16 | 386 | While this project should work for other systems, no compatibility guarantees are made for those systems currently. +Go 1.18 was added in March of 2022. Go 1.16 will be removed around June 2022 + ## Getting Started You can find a getting started guide on [opentelemetry.io](https://opentelemetry.io/docs/go/getting-started/). From e80e69ab54227e28434217035edd6f09da3d4391 Mon Sep 17 00:00:00 2001 From: Chester Cheung Date: Thu, 17 Mar 2022 10:47:59 +0800 Subject: [PATCH 3/6] Update CHANGELOG.md Co-authored-by: Tyler Yahn --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ec36f20d8c3..cd34f6b8c73 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -35,7 +35,7 @@ This update is a breaking change of the unstable Metrics API. Code instrumented Zero or negative values will not be changed to the default value like `WithSpanLimits` does. Setting a limit to zero will effectively disable the related resource it limits and setting to a negative value will mean that resource is unlimited. Consequentially, limits should be constructed using `NewSpanLimits` and updated accordingly. (#2637) -- Add go 1.18 to our compatibility tests. (#????) +- Add go 1.18 to our compatibility tests. (#2679) ### Changed From 67cc5a7087fca6d3f69baf8363a4d6c14611235a Mon Sep 17 00:00:00 2001 From: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com> Date: Fri, 18 Mar 2022 08:27:45 -0500 Subject: [PATCH 4/6] Update README.md MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Robert Pająk --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index cb57fc7127f..e248cf4c5f3 100644 --- a/README.md +++ b/README.md @@ -60,7 +60,8 @@ This project is tested on the following systems. While this project should work for other systems, no compatibility guarantees are made for those systems currently. -Go 1.18 was added in March of 2022. Go 1.16 will be removed around June 2022 +Go 1.18 was added in March of 2022. +Go 1.16 will be removed around June 2022. ## Getting Started From a12ad0f80dbf02e09109ef515656f0318ea094ee Mon Sep 17 00:00:00 2001 From: Aaron Clawson <3766680+MadVikingGod@users.noreply.github.com> Date: Fri, 18 Mar 2022 13:30:49 +0000 Subject: [PATCH 5/6] Move default go version back to 1.16 --- .github/workflows/benchmark.yml | 2 +- .github/workflows/ci.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/benchmark.yml b/.github/workflows/benchmark.yml index 76309765c94..8366db387dd 100644 --- a/.github/workflows/benchmark.yml +++ b/.github/workflows/benchmark.yml @@ -4,7 +4,7 @@ on: branches: - main env: - DEFAULT_GO_VERSION: 1.17 + DEFAULT_GO_VERSION: 1.16 jobs: benchmark: name: Benchmarks diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b3030d751fb..1c16023015b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -8,7 +8,7 @@ env: # Path to where test results will be saved. TEST_RESULTS: /tmp/test-results # Default minimum version of Go to support. - DEFAULT_GO_VERSION: 1.17 + DEFAULT_GO_VERSION: 1.16 jobs: lint: runs-on: ubuntu-latest From 959425503d471a2923ec40f27851cf4b2a8d7eaa Mon Sep 17 00:00:00 2001 From: Tyler Yahn Date: Fri, 18 Mar 2022 09:29:59 -0700 Subject: [PATCH 6/6] Move changelog entry to unreleased section --- CHANGELOG.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 15b323bf72e..b4c0d047217 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -13,6 +13,10 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm This update is a breaking change of the unstable Metrics API. Code instrumented with the `go.opentelemetry.io/otel/metric` will need to be modified. +### Added + +- Add go 1.18 to our compatibility tests. (#2679) + ### Changed - The metrics API has been significantly changed. (#2587) @@ -46,7 +50,6 @@ Code instrumented with the `go.opentelemetry.io/otel/metric` will need to be mod Zero or negative values will not be changed to the default value like `WithSpanLimits` does. Setting a limit to zero will effectively disable the related resource it limits and setting to a negative value will mean that resource is unlimited. Consequentially, limits should be constructed using `NewSpanLimits` and updated accordingly. (#2637) -- Add go 1.18 to our compatibility tests. (#2679) ### Changed