Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus exporter is incomplete #652

Closed
3 tasks
moorara opened this issue Apr 21, 2020 · 2 comments
Closed
3 tasks

Prometheus exporter is incomplete #652

moorara opened this issue Apr 21, 2020 · 2 comments

Comments

@moorara
Copy link
Contributor

moorara commented Apr 21, 2020

It seems the metric exporter for Prometheus is not yet complete. Specifically, I noticed the following features are missing:

  • Histogram metrics
  • Metric names are not namespace with the name passed to Meter
  • Labels are not reported

Is there any ongoing work to address these issues? If not, I can start working on them.

@jmacd
Copy link
Contributor

jmacd commented Apr 28, 2020

Hi @moorara,
Sorry about the confusion. To these three points:
(1) Histogram is used for Measure instruments by default. What version did you test with?
(2) OTel has decided that Meter names are not to be treated as namespaces, those names are meant to identify the instrumenting library. This allows us to swap libraries that report the same metric. See open-telemetry/opentelemetry-specification#552
(3) I'm pretty sure labels are reported, how did you test this? There's an open issue about Resources at the moment, which would map into "Const Labels" in prometheus, but that was just opened because resource support was added only recently.

I suspect the biggest source of confusion here is that the Prometheus exporter is not very configurable. For example, how do you set histogram boundaries? This is going to be the subject of the "Views API". See open-telemetry/oteps#89.

I'm going to close this since I believe each of the points you raised is actually addressed. Thanks.

@jmacd jmacd closed this as completed Apr 28, 2020
@moorara
Copy link
Contributor Author

moorara commented Apr 30, 2020

Hi @jmacd,

Thanks for explaining. I can confirm with the latest release of opentelemetry-go, these issues are addressed, however there's a bigger issue IMO. I opened the following issue for tracking it.
#689

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants