Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dogstatsd exporter #543

Closed
jmacd opened this issue Mar 11, 2020 · 2 comments · Fixed by #591
Closed

Remove dogstatsd exporter #543

jmacd opened this issue Mar 11, 2020 · 2 comments · Fixed by #591
Labels
area:metrics Part of OpenTelemetry Metrics

Comments

@jmacd
Copy link
Contributor

jmacd commented Mar 11, 2020

This code should move to a contrib or vendor repository.

I had pursued the idea of putting together a specification for statsd + labels like dogstatsd, but I couldn't find much support for this idea. Dogstatsd, while it is widely used outside of Datadog, does not have a specification that we can use.

@jmacd jmacd added the area:metrics Part of OpenTelemetry Metrics label Mar 11, 2020
@lizthegrey
Copy link
Member

where does this put things like Telegraf that are officially maintained by InfluxDB but in reality are used by everyone?

@jmacd
Copy link
Contributor Author

jmacd commented Mar 12, 2020

My feeling is that statsd+labels is a very useful protocol and we should support it.

I've engaged in private conversations, trying to find anyone that will produce a viable statsd+labels protocol spec. Even "plain" statsd lacks a proper specification, and I would support a plain statsd exporter too, although I think it it less useful in practice--and it's wasteful to encode labels into the metric name and parse them out later which is how many systems treat plain statsd (e.g., https://github.com/prometheus/statsd_exporter, https://www.datadoghq.com/blog/dogstatsd-mapper).

I really expected that someone with a vested interested in OTel+STatsd being an official thing would step up here, but since it's so close to our beta, I'm interested in removing non-standard code. This is not my fight--I was trying to help by creating the OTel-Go statsd code. If we did have a spec for statsd+labels, I am opposed to using what Datadog has given us. There is an unsolved issue that to me makes-or-breaks this protocol, DataDog/datadog-go#83, and currently it's broken. What we need is an improved statsd+labels protocol, IMO it's very simple to specify but it should give us details about the character set and support escaping values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants