Truncate and de-duplicate log attribute values #5230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:SDK
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5230 +/- ##
=====================================
Coverage 84.4% 84.4%
=====================================
Files 265 265
Lines 17480 17522 +42
=====================================
+ Hits 14756 14796 +40
- Misses 2413 2415 +2
Partials 311 311
|
MrAlias
force-pushed
the
limit-log-record-vals
branch
2 times, most recently
from
52d7f5b
to
44177d8
Compare
|
We need a way to set the attribute value length limit for a record outside of the i.e. #5192 |
MrAlias
force-pushed
the
limit-log-record-vals
branch
from
c5c0e57
to
50bcb91
Compare
MrAlias
force-pushed
the
limit-log-record-vals
branch
from
75a0e03
to
678d737
Compare
MrAlias
requested review from
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
dashpole
reviewed
Apr 26, 2024
dashpole
approved these changes
Apr 26, 2024
dmathieu
approved these changes
Apr 29, 2024
MrAlias
added a commit
to MrAlias/opentelemetry-go
that referenced
this pull request
Apr 29, 2024
MrAlias
added a commit
to MrAlias/opentelemetry-go
that referenced
this pull request
Apr 29, 2024
MrAlias
added a commit
that referenced
this pull request
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #5217
Resolve #5218
Resolve #5086