Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs SDK design #4896

Closed
pellared opened this issue Feb 9, 2024 · 3 comments · Fixed by #4954
Closed

Logs SDK design #4896

pellared opened this issue Feb 9, 2024 · 3 comments · Fixed by #4954
Assignees
Labels
area:logs Part of OpenTelemetry logs documentation Provides helpful information pkg:SDK Related to an SDK package
Milestone

Comments

@pellared
Copy link
Member

pellared commented Feb 9, 2024

Create a design for Logs SDK similarly to #4809.

Prior art: #3606

@pellared pellared added documentation Provides helpful information pkg:SDK Related to an SDK package area:logs Part of OpenTelemetry logs labels Feb 9, 2024
@pellared pellared changed the title Add Logs SDK design doc Logs SDK design Feb 9, 2024
@pellared pellared self-assigned this Feb 20, 2024
@MrAlias
Copy link
Contributor

MrAlias commented Feb 21, 2024

Talking with @pellared offline, we likely want to try and use the OTLP proto as our data model if we can for the SDK:

  • it is the only expected output format
  • it will help preserve the optimizations we how to provide by default

We will need to look into if this is feasible. Namely, if it can be done without taking a dependency on gRPC.

@pellared
Copy link
Member Author

We will need to look into if this is feasible. Namely, if it can be done without taking a dependency on gRPC.

Related issues:

@pellared
Copy link
Member Author

SIG meeting:
Depending on OTLP Go-proto as our data model may lead to issues as there are no guarantee that protoc-gen-go will always generate backwards-compatible code. It would be safer if SDK defines the data model unless the benchmarks will show significant differences to favor Go-proto code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:logs Part of OpenTelemetry logs documentation Provides helpful information pkg:SDK Related to an SDK package
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants