Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Note about dropping go 1.18 #3771

Merged
merged 5 commits into from
Feb 27, 2023

Conversation

MadVikingGod
Copy link
Contributor

This is a simple change to note the dropping support of 1.18

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #3771 (9e49e97) into main (b177f58) will increase coverage by 0.0%.
The diff coverage is n/a.

❗ Current head 9e49e97 differs from pull request most recent head dd10a1b. Consider uploading reports for the commit dd10a1b to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3771   +/-   ##
=====================================
  Coverage   81.7%   81.7%           
=====================================
  Files        167     167           
  Lines      12453   12459    +6     
=====================================
+ Hits       10175   10181    +6     
  Misses      2063    2063           
  Partials     215     215           
Impacted Files Coverage Δ
exporters/jaeger/jaeger.go 90.3% <0.0%> (-0.9%) ⬇️
sdk/metric/pipeline.go 90.5% <0.0%> (-0.1%) ⬇️
sdk/metric/meter.go 89.5% <0.0%> (ø)
sdk/metric/instrument.go 95.7% <0.0%> (ø)
sdk/metric/metricdata/data.go 57.1% <0.0%> (ø)
metric/instrument/syncint64.go 100.0% <0.0%> (ø)
metric/instrument/asyncint64.go 100.0% <0.0%> (ø)
metric/instrument/instrument.go 100.0% <0.0%> (ø)
exporters/prometheus/exporter.go 83.5% <0.0%> (ø)
metric/instrument/syncfloat64.go 100.0% <0.0%> (ø)
... and 4 more

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@MrAlias MrAlias added this to the v1.14.0 milestone Feb 27, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Robert Pająk <pellared@hotmail.com>
@MrAlias MrAlias merged commit 46d7f8d into open-telemetry:main Feb 27, 2023
@MadVikingGod MadVikingGod deleted the mvg/1.18-notice branch February 27, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants