Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OTEL_METRIC_EXPORT_INTERVAL and OTEL_METRIC_EXPORT_TIMEOUT #3763

Merged
merged 8 commits into from
Feb 24, 2023

Conversation

pellared
Copy link
Member

Fixes #3731

@codecov
Copy link

codecov bot commented Feb 22, 2023

Codecov Report

Merging #3763 (2edf7ad) into main (3d6a643) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3763     +/-   ##
=======================================
- Coverage   81.7%   81.6%   -0.1%     
=======================================
  Files        166     167      +1     
  Lines      12444   12459     +15     
=======================================
+ Hits       10168   10179     +11     
- Misses      2061    2065      +4     
  Partials     215     215             
Impacted Files Coverage Δ
sdk/metric/reader.go 100.0% <ø> (ø)
sdk/metric/env.go 100.0% <100.0%> (ø)
sdk/metric/periodic_reader.go 91.6% <100.0%> (ø)
sdk/trace/batch_span_processor.go 80.2% <0.0%> (-1.8%) ⬇️

@dmathieu
Copy link
Member

Trace environment variables are configured in sdk/internal/env, which is not trace specific.
Shouldn't we reuse this pattern for metrics, and therefore set that up in the same package?

@pellared
Copy link
Member Author

pellared commented Feb 23, 2023

Trace environment variables are configured in sdk/internal/env, which is not trace specific. Shouldn't we reuse this pattern for metrics, and therefore set that up in the same package?

I would rather tackle it "more globally". PTAL #3766

@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Feb 23, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
sdk/metric/env.go Outdated Show resolved Hide resolved
pellared and others added 2 commits February 24, 2023 08:58
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@MadVikingGod MadVikingGod merged commit 1d6704c into open-telemetry:main Feb 24, 2023
@pellared pellared deleted the MetricReader-env-vars branch February 24, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
Development

Successfully merging this pull request may close these issues.

Support OTEL_METRIC_EXPORT_INTERVAL and OTEL_METRIC_EXPORT_TIMEOUT
4 participants