Accept scope attributes during Tracer creation #3739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OTel specification requires the instrumentation attributes are accepted by the API for the Tracer. This adds a TracerOption to satisfy that requirement.
MrAlias
added
pkg:API
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3739 +/- ##
=====================================
Coverage 81.6% 81.6%
=====================================
Files 166 166
Lines 12435 12442 +7
=====================================
+ Hits 10155 10164 +9
+ Misses 2065 2063 -2
Partials 215 215
|
dmathieu
approved these changes
Feb 17, 2023
dashpole
approved these changes
Feb 17, 2023
MadVikingGod
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OTel specification requires the instrumentation attributes are accepted by the API for the Tracer. This adds a
TracerOptionto satisfy that requirement.Part of #3368