Update ServerRequest to accept server name

[MrAlias]

The net.host.name and net.host.port need to be set to the primary server name if it is known¹. Currently, the ServerRequest function provided by the httpconv packages do not include this in the processing of relevant attributes. This means for a user of these packages that know the primary server name, they need to manually added the attribute after a call to ServerRequest. This relies on the last-one-wins semantics of a span SetAttributes method which is not common knowledge, nor should it be needed for a user to correctly have their attributes defined.

Instead, update the ServerRequest method accept the server and use it to decide on how to construct the appropriate attributes.

Footnotes

1. https://github.com/open-telemetry/opentelemetry-specification/blob/v1.17.0/specification/trace/semantic_conventions/http.md#http-server-semantic-conventions ↩

[codecov]

Codecov Report

Merging #3619 (b8b98d2) into main (7e5d903) will increase coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #3619   +/-   ##
=====================================
  Coverage   79.4%   79.4%           
=====================================
  Files        170     170           
  Lines      12645   12654    +9     
=====================================
+ Hits       10043   10052    +9     
  Misses      2392    2392           
  Partials     210     210           

Impacted Files	Coverage Δ
semconv/internal/v2/http.go	100.0% <100.0%> (ø)
exporters/jaeger/jaeger.go	90.3% <0.0%> (-0.9%)	⬇️
sdk/trace/batch_span_processor.go	81.1% <0.0%> (+0.8%)	⬆️

[dmathieu]

Isn't this a breaking change for the semconv/vxxx/httpconv packages? Shouldn't there be a changelog entry?

[MrAlias]

Isn't this a breaking change for the semconv/vxxx/httpconv packages? Shouldn't there be a changelog entry?

The code this changes hasn't been released yet.