Change ClientResponse to accept an *http.Response #3617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3617 +/- ##
=====================================
Coverage 79.4% 79.4%
=====================================
Files 170 170
Lines 12628 12628
=====================================
Hits 10030 10030
Misses 2388 2388
Partials 210 210
|
dashpole
approved these changes
Jan 25, 2023
Aneurysm9
approved these changes
Jan 25, 2023
dmathieu
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
net/httppackage returns a*Responsevalue from all the functions and methods to perform requests. Having to dereference the value to pass to thehttpconv.ClientResponsefunction is ergonomically not ideal. This changes the unrelease API for the v1.13.0, v1.14.0, v1.15.0, v1.16.0, and v1.17.0 semconv packages and the underlying generator to accept a pointer value instead.