Redefine gauge in Prometheus example to be a Gauge #3498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
the
pkg:exporter:prometheus
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Aneurysm9
approved these changes
Nov 29, 2022
|
UpDown counters are converted to prometheus gauges: https://github.com/open-telemetry/opentelemetry-go/blob/main/exporters/prometheus/exporter.go#L191. Since many OTel instruments (sync UpDownCounter, async Gauge, async UpDownCounter) all convert to prometheus gauges, this was trying to demonstrate the synchronous gauge case. We could change it to an async gauge if that makes it less confusing. |
SGTM. I'll make the change. |
MrAlias
changed the title
MrAlias
changed the title
dashpole
approved these changes
Nov 29, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3498 +/- ##
=======================================
- Coverage 78.0% 78.0% -0.1%
=======================================
Files 165 165
Lines 11755 11755
=======================================
- Hits 9179 9177 -2
- Misses 2380 2382 +2
Partials 196 196
|
hanyuancheung
approved these changes
Nov 29, 2022
MadVikingGod
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3493