Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds an Attribute assertion to metric data test #3487

Merged
merged 7 commits into from Nov 29, 2022

Conversation

MadVikingGod
Copy link
Contributor

This is an attempt to solve the immediate problem of #3435.

It creates a new Assert function that will check if the attributes on ALL DataPoints contain the Attributes provided.

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Merging #3487 (6774d23) into main (d7b3115) will increase coverage by 0.1%.
The diff coverage is 95.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3487     +/-   ##
=======================================
+ Coverage   77.9%   78.0%   +0.1%     
=======================================
  Files        165     165             
  Lines      11634   11755    +121     
=======================================
+ Hits        9066    9179    +113     
- Misses      2372    2380      +8     
  Partials     196     196             
Impacted Files Coverage Δ
sdk/metric/metricdata/metricdatatest/assertion.go 80.6% <89.1%> (+5.2%) ⬆️
...dk/metric/metricdata/metricdatatest/comparisons.go 97.5% <97.6%> (+<0.1%) ⬆️
exporters/jaeger/jaeger.go 90.3% <0.0%> (-0.9%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants