Add View, NewView, Instrument, Stream, and InstrumentKind to sdk/metric with unit tests #3459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
added
pkg:SDK
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3459 +/- ##
=======================================
+ Coverage 77.7% 77.9% +0.1%
=======================================
Files 164 165 +1
Lines 11538 11620 +82
=======================================
+ Hits 8975 9052 +77
- Misses 2368 2372 +4
- Partials 195 196 +1
|
4 tasks
MrAlias
requested review from
jmacd,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
Aneurysm9
reviewed
Nov 10, 2022
Co-authored-by: Anthony Mirabella <a9@aneurysm9.com>
dashpole
reviewed
Nov 11, 2022
dashpole
reviewed
Nov 11, 2022
dashpole
approved these changes
Nov 11, 2022
This was referenced Nov 11, 2022
Merged
hanyuancheung
approved these changes
Nov 14, 2022
MadVikingGod
approved these changes
Nov 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 1 of 4 from #3399