Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not handle empty partial OTLP successes #3438

Merged
merged 4 commits into from Nov 3, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Nov 2, 2022

Fix #3432.

The OTLP server will respond with empty partial success responses (i.e. empty messages and 0 count). Treat these as equivalent to it not being set/present like the documentation specifies in the proto: https://github.com/open-telemetry/opentelemetry-proto/blob/724e427879e3d2bae2edc0218fff06e37b9eb46e/opentelemetry/proto/collector/trace/v1/trace_service.proto#L58

Fix open-telemetry#3432.

The OTLP server will respond with empty partial success responses (i.e.
empty messages and 0 count). Treat these as equivalent to it not being
set/present like the documentation specifies in the proto:
https://github.com/open-telemetry/opentelemetry-proto/blob/724e427879e3d2bae2edc0218fff06e37b9eb46e/opentelemetry/proto/collector/trace/v1/trace_service.proto#L58
@MrAlias MrAlias added bug Something isn't working area:trace Part of OpenTelemetry tracing pkg:exporter:otlp Related to the OTLP exporter package labels Nov 2, 2022
@MrAlias MrAlias added this to the Release v1.12.0 milestone Nov 2, 2022
@MrAlias MrAlias marked this pull request as draft November 2, 2022 16:15
@MrAlias MrAlias marked this pull request as ready for review November 2, 2022 16:21
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #3438 (54b3fe3) into main (e8023fa) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3438     +/-   ##
=======================================
- Coverage   77.8%   77.8%   -0.1%     
=======================================
  Files        164     164             
  Lines      11488   11494      +6     
=======================================
+ Hits        8940    8944      +4     
- Misses      2345    2347      +2     
  Partials     203     203             
Impacted Files Coverage Δ
exporters/otlp/internal/partialsuccess.go 100.0% <100.0%> (ø)
exporters/otlp/otlptrace/otlptracegrpc/client.go 92.5% <100.0%> (ø)
exporters/otlp/otlptrace/otlptracehttp/client.go 76.4% <100.0%> (ø)
sdk/trace/batch_span_processor.go 80.2% <0.0%> (-0.9%) ⬇️

@MrAlias MrAlias merged commit b5b6852 into open-telemetry:main Nov 3, 2022
@MrAlias MrAlias deleted the fix-3432 branch March 20, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:trace Part of OpenTelemetry tracing bug Something isn't working pkg:exporter:otlp Related to the OTLP exporter package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extraneous Partial Success Error Message Exporting Traces to OTel Collector
5 participants