Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set IsMonotonic to true for opencensus sum #3389

Merged
merged 6 commits into from Oct 27, 2022
Merged

Set IsMonotonic to true for opencensus sum #3389

merged 6 commits into from Oct 27, 2022

Conversation

ktong
Copy link
Contributor

@ktong ktong commented Oct 21, 2022

fix #3388

@dashpole
Copy link
Contributor

You will need to update a few unit tests:

And please add an entry in CHANGELOG.md under the Fixed heading

@dashpole dashpole added bug Something isn't working pkg:bridges Related to a bridge package labels Oct 21, 2022
@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #3389 (0753059) into main (667a201) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3389     +/-   ##
=======================================
- Coverage   77.9%   77.9%   -0.1%     
=======================================
  Files        164     164             
  Lines      11359   11359             
=======================================
- Hits        8859    8857      -2     
- Misses      2301    2303      +2     
  Partials     199     199             
Impacted Files Coverage Δ
bridge/opencensus/internal/ocmetric/metric.go 93.8% <100.0%> (ø)
sdk/trace/batch_span_processor.go 81.1% <0.0%> (-0.9%) ⬇️

@MrAlias MrAlias added the area:metrics Part of OpenTelemetry Metrics label Oct 21, 2022
@MrAlias MrAlias added this to the Metric v0.34.0 milestone Oct 21, 2022
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
@MrAlias MrAlias merged commit 94ae231 into open-telemetry:main Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics bug Something isn't working pkg:bridges Related to a bridge package
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

IsMonotonic is inconsistent for opencensus bridge between go and java
4 participants