Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new env config options for OTLP exporter #3363

Merged
merged 13 commits into from Nov 8, 2022

Conversation

seankhliao
Copy link
Contributor

spec: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/protocol/exporter.md#configuration-options

Add the INSECURE CLIENT_CERTIFICATE and CLIENT_KEY env options for the otlp exporters

exporters/otlp/internal/envconfig/envconfig.go Outdated Show resolved Hide resolved
exporters/otlp/internal/envconfig/envconfig.go Outdated Show resolved Hide resolved
exporters/otlp/internal/envconfig/envconfig.go Outdated Show resolved Hide resolved
exporters/otlp/internal/envconfig/envconfig_test.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #3363 (88e8bff) into main (c21b6b6) will decrease coverage by 0.0%.
The diff coverage is 63.3%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3363     +/-   ##
=======================================
- Coverage   77.8%   77.7%   -0.1%     
=======================================
  Files        164     164             
  Lines      11497   11572     +75     
=======================================
+ Hits        8945    8992     +47     
- Misses      2349    2373     +24     
- Partials     203     207      +4     
Impacted Files Coverage Δ
...orters/otlp/otlpmetric/internal/oconf/envconfig.go 89.5% <50.0%> (-10.5%) ⬇️
...rs/otlp/otlptrace/internal/otlpconfig/envconfig.go 89.5% <50.0%> (-10.5%) ⬇️
exporters/otlp/internal/envconfig/envconfig.go 82.8% <72.2%> (-12.8%) ⬇️
exporters/jaeger/jaeger.go 91.1% <0.0%> (+0.8%) ⬆️
sdk/trace/batch_span_processor.go 81.9% <0.0%> (+1.7%) ⬆️

@seankhliao
Copy link
Contributor Author

not sure what to do with coverage as the other places i modified don't seem to have tests in place

exporters/otlp/internal/envconfig/envconfig.go Outdated Show resolved Hide resolved
exporters/otlp/internal/envconfig/envconfig.go Outdated Show resolved Hide resolved
exporters/otlp/internal/envconfig/envconfig.go Outdated Show resolved Hide resolved
exporters/otlp/internal/envconfig/envconfig.go Outdated Show resolved Hide resolved
exporters/otlp/internal/envconfig/envconfig.go Outdated Show resolved Hide resolved
exporters/otlp/internal/envconfig/envconfig.go Outdated Show resolved Hide resolved
exporters/otlp/internal/envconfig/envconfig.go Outdated Show resolved Hide resolved
seankhliao and others added 7 commits November 4, 2022 13:25
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@hanyuancheung
Copy link
Member

Seems the changelog has conflicts, please resolve them.

@seankhliao
Copy link
Contributor Author

resolved

@MrAlias
Copy link
Contributor

MrAlias commented Nov 8, 2022

@Aneurysm9 does this look good to you?

@MrAlias MrAlias merged commit 2694dbf into open-telemetry:main Nov 8, 2022
@seankhliao seankhliao deleted the otlp-env branch November 9, 2022 04:21
@MrAlias MrAlias added this to the Release v1.11.2 milestone Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants