fix wrong representation of status value in zipkin exporter #3340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NewReStarter
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
NewReStarter
changed the title
Status Code name to fully upper case
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3340 +/- ##
=====================================
Coverage 77.9% 77.9%
=====================================
Files 164 164
Lines 11359 11361 +2
=====================================
+ Hits 8859 8861 +2
Misses 2301 2301
Partials 199 199
|
|
I'm not sure this is the proper fix. Even though I think the uppercasing should happen within the zipkin exporter, not for all codes. |
MrAlias
requested changes
Oct 17, 2022
NewReStarter
changed the title
NewReStarter
force-pushed
the
fix-zipkin-statuscode
branch
from
0878205
to
62bd8a8
Compare
Thx, I didn't notice the side effect. New version of this fix has been submitted, please help do the further review. |
dmathieu
reviewed
Oct 18, 2022
dmathieu
approved these changes
Oct 18, 2022
MrAlias
reviewed
Oct 18, 2022
correct the usage of case-sensitive terms Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
hanyuancheung
approved these changes
Oct 24, 2022
MrAlias
reviewed
Oct 27, 2022
MrAlias
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3287
Set the name of span status code to upper case, from
Unset,Ok,ErrortoUNSET,OK,ERRORwithout making breaking changes. Previous version of code names can still be parsed.