Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Aggregation/Temporality selection to the Exporter interface #3260

Merged
merged 29 commits into from Nov 1, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Oct 4, 2022

The OpenTelemetry specification defines the metric exporter interface as a type that defines the aggregation and temporality properties of the Metric SDK through the reader they are registered with:

The aggregation and temporality properties used by the OpenTelemetry Metric SDK are determined when registering Metric Exporters through their associated MetricReader.

Similar to the Java and Python, this updates the Exporter interface to handle this communication of values through their associated reader.

Related to #3244

@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Oct 4, 2022
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #3260 (23c85af) into main (c8a13d6) will decrease coverage by 0.2%.
The diff coverage is 61.8%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3260     +/-   ##
=======================================
- Coverage   77.9%   77.7%   -0.3%     
=======================================
  Files        164     164             
  Lines      11361   11457     +96     
=======================================
+ Hits        8861    8909     +48     
- Misses      2301    2346     +45     
- Partials     199     202      +3     
Impacted Files Coverage Δ
exporters/otlp/otlpmetric/otlpmetricgrpc/config.go 41.8% <0.0%> (-3.3%) ⬇️
exporters/otlp/otlpmetric/otlpmetrichttp/config.go 85.7% <0.0%> (-14.3%) ⬇️
sdk/metric/aggregation/aggregation.go 77.4% <ø> (ø)
sdk/metric/reader.go 100.0% <ø> (+24.4%) ⬆️
exporters/otlp/otlpmetric/exporter.go 67.2% <25.0%> (-17.8%) ⬇️
exporters/otlp/otlpmetric/otlpmetricgrpc/client.go 84.9% <42.8%> (-3.0%) ⬇️
exporters/otlp/otlpmetric/otlpmetrichttp/client.go 77.5% <42.8%> (-1.6%) ⬇️
sdk/metric/manual_reader.go 78.6% <65.2%> (-6.0%) ⬇️
...xporters/otlp/otlpmetric/internal/oconf/options.go 79.8% <72.4%> (-1.7%) ⬇️
exporters/stdout/stdoutmetric/config.go 72.9% <72.4%> (-0.8%) ⬇️
... and 7 more

@MrAlias MrAlias marked this pull request as ready for review October 18, 2022 21:05
@MrAlias MrAlias added this to the Metric SDK: Beta milestone Oct 18, 2022
@MrAlias MrAlias removed this from the Metric SDK: Beta milestone Oct 20, 2022
@MrAlias MrAlias added this to the Metric v0.34.0 milestone Oct 27, 2022
@MrAlias MrAlias merged commit 48a0547 into open-telemetry:main Nov 1, 2022
@MrAlias MrAlias deleted the exp-agg-tempor branch November 1, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants