Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass res to exporter #3250

Merged
merged 1 commit into from Oct 2, 2022
Merged

pass res to exporter #3250

merged 1 commit into from Oct 2, 2022

Conversation

ktong
Copy link
Contributor

@ktong ktong commented Sep 30, 2022

Follow #3206 to pass res to &exporter

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 30, 2022 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ktong / name: Kuisong Tong (4d95412)

@codecov
Copy link

codecov bot commented Sep 30, 2022

Codecov Report

Merging #3250 (4d95412) into main (aca054b) will not change coverage.
The diff coverage is 0.0%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3250   +/-   ##
=====================================
  Coverage   77.3%   77.3%           
=====================================
  Files        159     159           
  Lines      11184   11184           
=====================================
  Hits        8651    8651           
  Misses      2335    2335           
  Partials     198     198
Impacted Files Coverage Δ
bridge/opencensus/metric.go 0.0% <0.0%> (ø)

dashpole
dashpole approved these changes Sep 30, 2022
View reviewed changes
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I had included this in #3207, but it is good to fix here.

@MrAlias MrAlias added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Oct 2, 2022
@MrAlias MrAlias merged commit efdbe5a into open-telemetry:main Oct 2, 2022
@ktong ktong deleted the patch-1 branch October 2, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

@MrAlias MrAlias MrAlias approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9 Aneurysm9 is a code owner

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod MadVikingGod is a code owner

@pellared pellared Awaiting requested review from pellared pellared is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung hanyuancheung is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ktong @dashpole @MrAlias