Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bucket default bounds #3222

Merged
merged 4 commits into from Oct 4, 2022
Merged

Update bucket default bounds #3222

merged 4 commits into from Oct 4, 2022

Conversation

dmathieu
Copy link
Member

Closes #3217

@codecov
Copy link

codecov bot commented Sep 22, 2022 •
edited

Codecov Report

Merging #3222 (9f35d1d) into main (3b657f7) will increase coverage by 0.0%.
The diff coverage is 100.0%.

❗ Current head 9f35d1d differs from pull request most recent head 85afd90. Consider uploading reports for the commit 85afd90 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3222   +/-   ##
=====================================
  Coverage   77.3%   77.3%           
=====================================
  Files        159     159           
  Lines      11182   11167   -15     
=====================================
- Hits        8651    8641   -10     
+ Misses      2333    2329    -4     
+ Partials     198     197    -1
Impacted Files Coverage Δ
sdk/metric/reader.go 75.5% <100.0%> (ø)
sdk/metric/provider.go 100.0% <0.0%> (ø)
sdk/trace/batch_span_processor.go 81.9% <0.0%> (+0.8%) ⬆️
sdk/metric/pipeline.go 97.2% <0.0%> (+1.2%) ⬆️

@MrAlias
Copy link
Contributor

MrAlias commented Oct 4, 2022

Blocked by open-telemetry/opentelemetry-specification#2851

@MrAlias MrAlias added this to the Metric v0.32.2 milestone Oct 4, 2022
@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Oct 4, 2022
@MrAlias MrAlias merged commit 697d245 into open-telemetry:main Oct 4, 2022
@MrAlias MrAlias mentioned this pull request Oct 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

@MadVikingGod MadVikingGod MadVikingGod approved these changes

@MrAlias MrAlias MrAlias approved these changes

@hanyuancheung hanyuancheung hanyuancheung approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9 Aneurysm9 is a code owner

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@pellared pellared Awaiting requested review from pellared pellared is a code owner

Assignees
No one assigned
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
None yet
Milestone
Metric v0.32.2
Development

Successfully merging this pull request may close these issues.

Update the explicit bucket default bounds
5 participants
@dmathieu @MrAlias @dashpole @MadVikingGod @hanyuancheung