Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flush pending telemetry when ForceFlush or Shutdown are called on a PeriodicReader #3220

Merged
merged 17 commits into from Sep 27, 2022

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Sep 21, 2022

Resolve #3209

@MrAlias MrAlias added pkg:SDK Related to an SDK package area:metrics Part of OpenTelemetry Metrics labels Sep 21, 2022
@MrAlias MrAlias added this to the Metric v0.32.1 milestone Sep 21, 2022
@MrAlias MrAlias changed the title [WIP] Flush pending telemetry when ForceFlush called Flush pending telemetry when ForceFlush called Sep 21, 2022
@MrAlias MrAlias changed the title Flush pending telemetry when ForceFlush called Flush pending telemetry when ForceFlush or Shutdown are called on a PeriodicReader Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #3220 (3f6932e) into main (8c6e6c4) will increase coverage by 0.0%.
The diff coverage is 91.4%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #3220   +/-   ##
=====================================
  Coverage   77.3%   77.3%           
=====================================
  Files        159     159           
  Lines      11134   11167   +33     
=====================================
+ Hits        8610    8639   +29     
- Misses      2327    2331    +4     
  Partials     197     197           
Impacted Files Coverage Δ
sdk/metric/periodic_reader.go 89.8% <91.4%> (-0.7%) ⬇️
exporters/jaeger/jaeger.go 90.3% <0.0%> (-0.9%) ⬇️
sdk/trace/batch_span_processor.go 81.9% <0.0%> (+0.8%) ⬆️

@MrAlias MrAlias merged commit 111a1d7 into open-telemetry:main Sep 27, 2022
@MrAlias MrAlias deleted the flush-mp branch September 27, 2022 15:05
@MrAlias MrAlias mentioned this pull request Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ForceFlush and Shutdown do not collect pending measurements
3 participants