Re-add previous metric bridge #3192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
requested review from
jmacd,
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
MadVikingGod,
pellared,
hanyuancheung and
dmathieu
as code owners
dashpole
force-pushed
the
old_metric_bridge
branch
4 times, most recently
from
4d7cd5c
to
164fcb4
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #3192 +/- ##
=======================================
- Coverage 77.4% 77.3% -0.2%
=======================================
Files 158 159 +1
Lines 11084 11101 +17
=======================================
Hits 8583 8583
- Misses 2306 2323 +17
Partials 195 195
|
MrAlias
approved these changes
Sep 19, 2022
dashpole
force-pushed
the
old_metric_bridge
branch
from
9789ecf
to
8d8ac9f
Compare
|
Depends on fix in #3193 |
jmacd
approved these changes
Sep 19, 2022
dashpole
force-pushed
the
old_metric_bridge
branch
from
8d8ac9f
to
0e99edf
Compare
|
I had to move the opencensusmetric/internal package because it wasn't accessible from where I wanted to place the bridge... |
|
rebased on the test fix |
hanyuancheung
approved these changes
Sep 20, 2022
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realized its ~trivial to support the previous method of invoking the OC metric bridge, so it might be best to include this, rather than break users until the new design is ready. See #3184 (comment)
Opening this as an option.