Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility add alt to image #3188

Merged
merged 1 commit into from Sep 19, 2022
Merged

Accessibility add alt to image #3188

merged 1 commit into from Sep 19, 2022

Conversation

Arhell
Copy link
Member

@Arhell Arhell commented Sep 18, 2022

@codecov
Copy link

codecov bot commented Sep 18, 2022 •
edited

Codecov Report

Merging #3188 (f8fde09) into main (baf9f18) will decrease coverage by 0.0%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main   #3188     +/-   ##
=======================================
- Coverage   77.4%   77.3%   -0.1%     
=======================================
  Files        158     158             
  Lines      11084   11084             
=======================================
- Hits        8583    8579      -4     
- Misses      2306    2310      +4     
  Partials     195     195
Impacted Files Coverage Δ
sdk/trace/batch_span_processor.go 80.2% <0.0%> (-0.9%) ⬇️
exporters/jaeger/jaeger.go 90.3% <0.0%> (-0.9%) ⬇️

@dmathieu dmathieu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 18, 2022
@MrAlias
Copy link
Contributor

MrAlias commented Sep 19, 2022

Depends on fix in #3193

@MrAlias MrAlias merged commit cce6304 into open-telemetry:main Sep 19, 2022
@Arhell Arhell deleted the add-alt branch September 19, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadVikingGod MadVikingGod MadVikingGod approved these changes

@MrAlias MrAlias MrAlias approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9 Aneurysm9 is a code owner

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@XSAM XSAM Awaiting requested review from XSAM XSAM is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@pellared pellared Awaiting requested review from pellared pellared is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung hanyuancheung is a code owner

@dmathieu dmathieu Awaiting requested review from dmathieu dmathieu is a code owner

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessibility add alt to image
4 participants
@Arhell @MrAlias @MadVikingGod @dmathieu