Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an example of view #3177

Merged
merged 5 commits into from Sep 26, 2022
Merged

Add an example of view #3177

merged 5 commits into from Sep 26, 2022

Conversation

tony612
Copy link
Contributor

@tony612 tony612 commented Sep 16, 2022

Add an example of custom histogram buckets and renaming in prometheus. See #689

@tony612 tony612 mentioned this pull request Sep 16, 2022
Closed
@dmathieu
Copy link
Member

I wonder if we shouldn't keep the base example simple, to not confuse folks who just get started. How about adding a new example instead of extending the current one?

@dmathieu dmathieu added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Sep 16, 2022
@tony612
Copy link
Contributor Author

tony612 commented Sep 16, 2022

@dmathieu How about moving it to a new example view to demo how to use view? Cc @MrAlias

@XSAM
Copy link
Member

XSAM commented Sep 16, 2022

@dmathieu How about moving it to a new example view to demo how to use view? Cc @MrAlias

That would be good. 👍

@tony612 tony612 changed the title Add an example of custom histogram buckets in prometheus Add an example of view Sep 19, 2022
XSAM
XSAM reviewed Sep 19, 2022
View reviewed changes
example/view/main.go Outdated Show resolved Hide resolved
MrAlias
MrAlias requested changes Sep 19, 2022
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having this as a new module means it needs to be included in our dependabot config (should happen if you run make) and versions.yaml.

@tony612 tony612 force-pushed the prom-view-example branch 2 times, most recently from 15d3406 to 48fb36f Compare September 20, 2022 05:04
@tony612
Copy link
Contributor Author

tony612 commented Sep 22, 2022

@MrAlias Please review again. Thanks.

MrAlias
MrAlias reviewed Sep 22, 2022
View reviewed changes
Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry

example/view/doc.go Outdated Show resolved Hide resolved
example/view/go.mod Outdated Show resolved Hide resolved
example/view/main.go Outdated Show resolved Hide resolved
example/view/main.go Outdated Show resolved Hide resolved
example/view/main.go Outdated Show resolved Hide resolved
example/view/main.go Outdated Show resolved Hide resolved
example/view/main.go Show resolved Hide resolved
tony612 and others added 2 commits September 23, 2022 10:52
@MrAlias MrAlias merged commit 8c6e6c4 into open-telemetry:main Sep 26, 2022
@tony612 tony612 deleted the prom-view-example branch October 2, 2022 01:08
This was referenced Oct 11, 2022
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmathieu dmathieu dmathieu approved these changes

@MrAlias MrAlias MrAlias approved these changes

@XSAM XSAM XSAM approved these changes

@jmacd jmacd Awaiting requested review from jmacd

@Aneurysm9 Aneurysm9 Awaiting requested review from Aneurysm9 Aneurysm9 is a code owner

@evantorrie evantorrie Awaiting requested review from evantorrie evantorrie is a code owner

@dashpole dashpole Awaiting requested review from dashpole dashpole is a code owner

@MadVikingGod MadVikingGod Awaiting requested review from MadVikingGod MadVikingGod is a code owner

@pellared pellared Awaiting requested review from pellared pellared is a code owner

@hanyuancheung hanyuancheung Awaiting requested review from hanyuancheung hanyuancheung is a code owner

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tony612 @dmathieu @XSAM @MrAlias