Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website_docs/libraries.md invalid HTTP link. #3074

Closed
rahuldimri opened this issue Aug 9, 2022 · 4 comments
Closed

website_docs/libraries.md invalid HTTP link. #3074

rahuldimri opened this issue Aug 9, 2022 · 4 comments
Labels
documentation Provides helpful information invalid This doesn't seem right

Comments

@rahuldimri
Copy link

When we click on the instrumentation libraries link we are getting 404 error.

image

@dmathieu
Copy link
Member

dmathieu commented Aug 9, 2022

The website_docs folder is meant to be built for the opentelemetry.io website. If you read the doc there, the link does work.

@rahuldimri
Copy link
Author

@dmathieu thanks for the info. one question is here is why do we have HTTP link reference on the .md files.

image

@dmathieu
Copy link
Member

dmathieu commented Aug 9, 2022

The markdown links are turned into actual links by the GitHub interface, there is nothing we can do about that. That's why there are links in that document.

@MadVikingGod MadVikingGod linked a pull request Aug 10, 2022 that will close this issue
@MrAlias
Copy link
Contributor

MrAlias commented Aug 10, 2022

Closed along with the #3075

This link is intended to be this way. The https://opentelemetry.io prefix was specifically dropped here: #2666

These files back the opentelemetry.io and are expected to have relative links to allow the communications SIG the freedom to move things without breaking this documentation.

@MrAlias MrAlias closed this as completed Aug 10, 2022
@MrAlias MrAlias added invalid This doesn't seem right documentation Provides helpful information labels Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Provides helpful information invalid This doesn't seem right
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants