Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to using Instrumentation Scope #2941

Closed
MadVikingGod opened this issue Jun 3, 2022 · 2 comments
Closed

Move to using Instrumentation Scope #2941

MadVikingGod opened this issue Jun 3, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@MadVikingGod
Copy link
Contributor

Problem Statement

There has been a move in the specification to change the name of Instrumentation Libary to Instrumentation Scope. Our implementation should move away from using Library to Scope.

Proposed Solution

Take this in steps:

  1. Create instrumentation.Scope that is the same shape as instrumentation.Library, and make Library an alias of Scope. This should be a non-breaking change, but should be checked.
  2. Deprecate Instrumentation.Library, and move all sdk uses to Scope.
  3. For each area in the SDK, trace metrics exporter etc, move as many references from Library to Scope. Examples would be internal struct names
    • For traces the biggest impediment is Span.InstrumentationLibrary(), we would need to add an extra Interface that could be checked and used1.
    • For Metrics there are a number of Interfaces that might need similar treatment

Alternatives

Change documentation to explain that Instrumentation Library should be treated as the Scope referenced in the specification.

Prior Art

Footnotes

  1. See the io.Seeker discussion in Module Compatibility - Working with interfaces

@MrAlias
Copy link
Contributor

MrAlias commented Jul 22, 2022

IIRC this was closed with #2977. @craigpastro please reopen this if not.

@MrAlias MrAlias closed this as completed Jul 22, 2022
@craigpastro
Copy link
Contributor

Thanks @MrAlias! If there is anything more I can help with please let me know. Otherwise, yeah, let's close it. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants
@MadVikingGod @MrAlias @craigpastro and others