Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate go-build-tools crosslink #2886

Merged
merged 10 commits into from May 6, 2022

Conversation

bryan-aguilar
Copy link
Contributor

@bryan-aguilar bryan-aguilar commented May 4, 2022

Updates the crosslink target to reference the go.opentelemetry.io/build-tools/crosslink package found here.

I have also ran crosslink prune to remove all the extraneous replace statements. No make target was added for crosslink prune but if desired we could either add a new target for that or pass in the --prune flag so that a prune is executed on every run.

Fixes #1529

@codecov
Copy link

codecov bot commented May 4, 2022

Codecov Report

Merging #2886 (f8af6c5) into main (c7cf945) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2886   +/-   ##
=====================================
  Coverage   75.7%   75.7%           
=====================================
  Files        177     177           
  Lines      11819   11819           
=====================================
+ Hits        8950    8954    +4     
+ Misses      2636    2632    -4     
  Partials     233     233           
Impacted Files Coverage Δ
sdk/trace/batch_span_processor.go 82.1% <0.0%> (+1.8%) ⬆️

@pellared
Copy link
Member

pellared commented May 5, 2022

pass in the --prune flag so that a prune is executed on every run.

At first glance, it seems the most effective approach. Any downsides if we do that?

@bryan-aguilar
Copy link
Contributor Author

At first glance, it seems the most effective approach. Any downsides if we do that?

There really isn't any in this context. While it's a destructive action the repository is already under version control so it's all completely reversible. Also, continually pruning would ensure that the go.mod files are kept clean. I would probably update the echo before the crosslink action is executed to provide more context so no one is surprised.

@bryan-aguilar bryan-aguilar requested a review from MrAlias May 5, 2022 18:53
@MrAlias MrAlias merged commit b51c221 into open-telemetry:main May 6, 2022
@MrAlias MrAlias added this to the Release v1.8.0 milestone Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prune auto-generated "replace" clauses in go.mod files
4 participants