Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] update resource initialization #2844

Merged
merged 8 commits into from Apr 25, 2022
Merged

[docs] update resource initialization #2844

merged 8 commits into from Apr 25, 2022

Conversation

cartermp
Copy link
Contributor

This is so SDK resources are set as well, not just the service name.

website_docs/manual.md Outdated Show resolved Hide resolved
@hanyuancheung hanyuancheung added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Apr 25, 2022
Copy link
Member

@XSAM XSAM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MrAlias MrAlias added the documentation Provides helpful information label Apr 25, 2022
@MrAlias MrAlias added this to the Release v1.7.0 milestone Apr 25, 2022
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #2844 (c349cbc) into main (1eef145) will increase coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #2844   +/-   ##
=====================================
  Coverage   75.7%   75.7%           
=====================================
  Files        180     180           
  Lines      11818   11818           
=====================================
+ Hits        8951    8953    +2     
+ Misses      2634    2632    -2     
  Partials     233     233           
Impacted Files Coverage Δ
exporters/jaeger/jaeger.go 91.1% <0.0%> (+0.8%) ⬆️

@MrAlias MrAlias merged commit b8e4241 into open-telemetry:main Apr 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Provides helpful information Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants