Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back the Prometheus example code #2803

Closed
MrAlias opened this issue Apr 19, 2022 · 3 comments · Fixed by #3168
Closed

Add back the Prometheus example code #2803

MrAlias opened this issue Apr 19, 2022 · 3 comments · Fixed by #3168
Assignees
@damemi
Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Milestone
Metric SDK: Alpha

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Apr 19, 2022 •
edited

Blocked by the metric SDK having a working example in the new_sdk/main branch

Removed in #2802
@MrAlias MrAlias added area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package labels Apr 19, 2022
@MrAlias MrAlias added this to the Metric SDK: Alpha milestone Apr 19, 2022
@hanyuancheung hanyuancheung mentioned this issue May 20, 2022
Closed
@MrAlias MrAlias mentioned this issue Sep 1, 2022
Merged
@MrAlias
Copy link
Contributor Author

MrAlias commented Sep 14, 2022

@damemi are you still able to work on this? I'm happy to pick it up if not.

@damemi damemi mentioned this issue Sep 14, 2022
Merged
@damemi
Copy link
Contributor

damemi commented Sep 14, 2022

@MrAlias yup! opened a PR at #3168, basically just copying examples from some of the tests and setting up an endpoint. please take a look

@MrAlias MrAlias linked a pull request Sep 14, 2022 that will close this issue
Add Prometheus exporter example #3168
Merged
@MrAlias
Copy link
Contributor Author

MrAlias commented Sep 15, 2022

Closed by #3168

@MrAlias MrAlias closed this as completed Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damemi damemi

Labels
area:metrics Part of OpenTelemetry Metrics pkg:SDK Related to an SDK package
Projects
No open projects
OpenTelemetry Go: Metric SDK (Alpha)
Status: Done
Milestone
Metric SDK: Alpha
Development

Successfully merging a pull request may close this issue.

Add Prometheus exporter example damemi/opentelemetry-go
2 participants
@damemi @MrAlias